Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - port the clean tactic from lean 3 to lean 4 #5909

Closed
wants to merge 8 commits into from

Conversation

mkaratarakis
Copy link
Collaborator


Open in Gitpod

@mkaratarakis mkaratarakis added the WIP Work in progress label Jul 14, 2023
@kmill
Copy link
Contributor

kmill commented Aug 1, 2023

I'd suggest that once #5717 is merged that we put this tactic in the DefeqTransformations file and use the runDefeqTactic function to run it, like the other tactics there. That means you don't have to reinvent how to run an expression-transformation tactic, and you get clean at h and clean at * for free.

@semorrison semorrison added the t-meta Tactics, attributes or user commands label Aug 6, 2023
@kmill
Copy link
Contributor

kmill commented Aug 25, 2023

Ah, I really misunderstood what this tactic was about. Now I understand that clean t is like exact t but removes type hints from t, so my suggestion to use the defeq transformations framework doesn't make sense.

@digama0 You write the original version of clean. It looks like it was only ever used in a single place in mathlib -- is it still useful? Should we turn it into a cleanHints% term elaborator instead? That way you can write stuff like let x := cleanHints% by ... or exact cleanHints% by .... Or maybe it could be a classical-like tactic that takes a tactic sequence instead of a term?

@digama0
Copy link
Member

digama0 commented Aug 25, 2023

I think it would make sense as a term elaborator.

@kmill kmill added awaiting-review and removed WIP Work in progress labels Aug 27, 2023
Mathlib/Tactic/Clean.lean Outdated Show resolved Hide resolved
@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:24
@semorrison semorrison changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 12:16
@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Sep 19, 2023
bors bot pushed a commit that referenced this pull request Sep 19, 2023


Co-authored-by: Kyle Miller <kmill31415@gmail.com>
@bors
Copy link

bors bot commented Sep 19, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title port the clean tactic from lean 3 to lean 4 [Merged by Bors] - port the clean tactic from lean 3 to lean 4 Sep 19, 2023
@bors bors bot closed this Sep 19, 2023
@bors bors bot deleted the clean branch September 19, 2023 12:54
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023


Co-authored-by: Kyle Miller <kmill31415@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-meta Tactics, attributes or user commands
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants