Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.Ring.Pi #1151

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port Algebra.Ring.Pi #1151

wants to merge 8 commits into from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Dec 21, 2022 •
edited by bors bot
Loading

No description provided.

@joneugster joneugster added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. blocked-by-theory-file blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) and removed WIP Work in progress blocked-by-theory-file labels Dec 21, 2022
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Dec 21, 2022
@eric-wieser
Copy link
Member

Note there is a Zulip thread about this file, which suggests we should eliminate the use of, rather than wait for, these tactics.

@joneugster joneugster added the WIP Work in progress label Dec 21, 2022
@joneugster joneugster added awaiting-review and removed WIP Work in progress labels Dec 21, 2022
mcdoll
mcdoll approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@mcdoll mcdoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I am biased in so far that I really want this merged.

maintainer merge

mcdoll
mcdoll reviewed Dec 22, 2022
View reviewed changes
Mathlib/Algebra/Ring/Pi.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Ring/Pi.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Ring/Pi.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Ring/Pi.lean Outdated Show resolved Hide resolved
jcommelin
jcommelin reviewed Dec 22, 2022
View reviewed changes
Mathlib/Algebra/Ring/Pi.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Ring/Pi.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Ring/Pi.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Ring/Pi.lean Outdated Show resolved Hide resolved
@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Dec 22, 2022
@mcdoll @jcommelin
Apply suggestions from code review
fadc166 
Co-authored-by: Johan Commelin <johan@commelin.net>
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 22, 2022
jcommelin
jcommelin approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 22, 2022
bors bot pushed a commit that referenced this pull request Dec 22, 2022
@joneugster @mcdoll
feat: port Algebra.Ring.Pi (#1151)
f5fe44e 
Co-authored-by: Moritz Doll <moritz.doll@googlemail.com>
@bors
Copy link

bors bot commented Dec 22, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.Ring.Pi [Merged by Bors] - feat: port Algebra.Ring.Pi Dec 22, 2022
@bors bors bot closed this Dec 22, 2022
@bors bors bot deleted the JE_algebra.ring.pi branch December 22, 2022 18:28
@github-actions github-actions bot mentioned this pull request Dec 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@mcdoll mcdoll mcdoll approved these changes

@jcommelin jcommelin jcommelin approved these changes

@Ruben-VandeVelde Ruben-VandeVelde Ruben-VandeVelde approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@joneugster @eric-wieser @jcommelin @mcdoll @Ruben-VandeVelde @semorrison