feat: allow configuring additional linters to run #881
+25
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grunweg
force-pushed
the
patch-2
branch
4 times, most recently
from
a3747dd
to
077f2de
Compare
|
awaiting-review |
github-actions
bot
added
the
awaiting-review
Extend getChecks to allow an additional list of linters, which is always run. This can be used downstream to e.g. enable the docBlameThm or explicitVarsOfIff linters without modifying batteries. As part of this, we - update and fix the function doc-string (which was quite outdated) - remove the useOnly option: the equivalent effect can be achieved by filtering the list of linters afterwards; *adding* linters cannot, hence must be performed in this function - rename a variable `dflt` to the more readable `default`
|
I just pushed a commit adding back the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
getChecksto allow an additional list of linters, which is always run. This can be used downstream to e.g. enable thedocBlameThmorexplicitVarsOfIfflinters without modifying batteries.As part of this, we
useOnlyoption: the equivalent effect can be achieved by filtering the list of linters afterwards; adding linters cannot, hence must be performed in this function. (That said, I'm happy to add this functionality back if desired.)dfltto the more readabledefaultNote that
test/lint_simpNF.leanlies on this (the docBlame linter warns there) - so this changed is already tested.