chore: avoid nonterminal simps in String/Lemmas #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es` and add an `inherit_doc`. (leanprover-community#861)
Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Bulhwi Cha <chabulhwi@semmalgil.com>
|
awaiting-review |
github-actions
bot
added
the
awaiting-review
semorrison
merged commit c4e7d52
into
leanprover-community:String_nonterminal_simps
2 checks passed
semorrison
added a commit
that referenced
this pull request
Jul 1, 2024
* chore: deal with nonterminal simps in String/Lemmas * fix * squeeze more simps * chore: avoid nonterminal simps in String/Lemmas (#864) * chore: bump toolchain to v4.9.0-rc3 (#858) * chore: replace `Std` with `Batteries` and recycle a doc-string (#859) * chore: `unreachableTactic` -- replace a `Std` namespace with `Batteries` and add an `inherit_doc`. (#861) * chore: avoid nonterminal simps in String/Lemmas Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Bulhwi Cha <chabulhwi@semmalgil.com> --------- Co-authored-by: Kim Morrison <kim@tqft.net> Co-authored-by: damiano <adomani@gmail.com> Co-authored-by: Mario Carneiro <di.gama@gmail.com> --------- Co-authored-by: Mario Carneiro <di.gama@gmail.com> Co-authored-by: Bulhwi Cha <chabulhwi@semmalgil.com> Co-authored-by: damiano <adomani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Mario Carneiro di.gama@gmail.com
Co-authored-by: Bulhwi Cha chabulhwi@semmalgil.com
The base branch of this pull request is the branch for #857.