getUserAgent() doesn't properly get the header because of conversion. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!👋
What kind of change does this PR introduce?
Description
request()->getUserAgent()doesn't return the user agent because it can't find the proper header name of it.The code flow is the following:
getUserAgent()
→ Headers::get('HTTP_USER_AGENT')
→ self::all()
→ findHeaders()
→ transforms 'HTTP_USER_AGENT' to 'User-Agent'
→ lookup fails because of the wrong key.
Fixing it
Inside Requests.php -> Request Class -> getUserAgent() Method;
We can simply "return Headers::get('USER-AGENT');" instead of "Headers::get('HTTP_USER_AGENT');.
Does this PR introduce a breaking change?
Related Issue