Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce HEREv3 (using apiKey instead of app_id and app_code) #343

Merged
merged 6 commits into from
Feb 1, 2020

Conversation

mcguffin
Copy link
Contributor

Use Tile API-URL and apiKey as described in latest HERE docs: https://developer.here.com/documentation/map-tile/dev_guide/topics/quick-start-map-tile.html
Will fix #342

@brunob
Copy link
Member

brunob commented Jan 28, 2020

@jieter any thoughts ?

@jieter
Copy link
Contributor

jieter commented Jan 28, 2020

Yes, the readme links to the preview, using [Available HEREv3 layers](http://leaflet-extras.github.io/leaflet-providers/preview/#filter=HEREv3), but 'HERE' is completely ignored from preview:

if (providerName.startsWith('HERE') || providerName.startsWith('OpenWeatherMap') || providerName.startsWith('MapBox')) {

The reason being that we kept exceeding the free plan, even with a single layer in the preview list.

I'd say there is limited value in adding these providers we cannot reliably show previews for, as they are not really discoverable.

@brunob
Copy link
Member

brunob commented Jan 28, 2020

@jieter nice catch maybe it could be better if @mcguffin remove the mention & link to preview for HERE in the readme ?

@brunob
Copy link
Member

brunob commented Feb 1, 2020

LGTM

@jieter jieter merged commit c2bc38a into leaflet-extras:master Feb 1, 2020
@jieter
Copy link
Contributor

jieter commented Feb 1, 2020

Merged, thanks @mcguffin

@stell
Copy link
Contributor

stell commented Feb 6, 2020

Can someone tag 1.9.2 with this update? Thanks!

@brunob
Copy link
Member

brunob commented Feb 6, 2020

@stell no hurry, we were waiting to merge others PR, now that it's done, we will shortly publish a new tag when our free time will allow it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use HERE apiKey v3 instead of legacy app_id and app_code
4 participants