Do not use retina suffix on some Stamen basemaps #287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @IvanSanchez / @JLuc, nice to have two solutions to choose from, thanks! I think I like #286 better because it is more explicit and thus closer to the purpose of leaflet-providers to just maintain a list of free providers. Being too smart (like we did before with homegrown retina detection) also makes it harder to maintain while the leaflet API evolves. |
|
Closing this one, anyway thx @IvanSanchez :) |
|
No problem at all! I just didn't realize @JLuc did a pull request while I was hacking together my solution :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #283 by explicitly setting the retina suffix to an empty string (instead of using the Leaflet default hard-coded in the
L.TileLayercode), but I haven't really tested it.This is an alternative to #286.