Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https support for CartoDB #237

Closed
wants to merge 2 commits into from
Closed

Conversation

ilyankou
Copy link

Fix #189

The idea is to have two properties, url and url2 for https and http protocols respectively, for those basemaps whose links are different for the two protocols (when // does not do the job).

@brunob
Copy link
Member

brunob commented Mar 18, 2017

This PR make me think that we may simply use https every time a provider allow it (and ditch http for these cases). This would simplify our code and it's not a problem or am i missing a point ?

Now that SSL is encouraged for everyone and doesn’t have performance concerns, this technique is now an anti-pattern. If the asset you need is available on SSL, then always use the https:// asset.

https://www.paulirish.com/2010/the-protocol-relative-url/

Any thoughts about it @jieter ?

@jieter
Copy link
Contributor

jieter commented Mar 18, 2017

Makes sense. Also helps for those working locally over the file:/// protocol.

brunob added a commit that referenced this pull request Sep 8, 2017
jieter pushed a commit that referenced this pull request Sep 8, 2017
@brunob
Copy link
Member

brunob commented Sep 8, 2017

closed in favor of #258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants