Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TryParse Method Signature for ICidrGuess #340

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

microalps
Copy link
Contributor

Resolves #339

@coveralls
Copy link

Pull Request Test Coverage Report for Build 707

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 94.558%

Files with Coverage Reduction New Missed Lines %
/src/System.Net.IPNetwork/IPNetwork2.cs 2 98.85%
Totals Coverage Status
Change from base Build 705: 0.04%
Covered Lines: 1616
Relevant Lines: 1709

💛 - Coveralls

@microalps
Copy link
Contributor Author

microalps commented Jan 31, 2025

@lduchosal While this PR was created, we have opted to switch to IPAddressRange that doesn't have this 'feature' at all and achieves the same goal with a clear API. Something so critical should be required method parameter or method named accordingly. Definitely not hidden in source where end-users are mistakenly thinking a blocklist is blocking a single IP and instead blocked entire networks. Feel free to take over this PR.

Copy link
Owner

@lduchosal lduchosal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks

@lduchosal lduchosal merged commit becfdee into lduchosal:master Jan 31, 2025
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Expose Method TryParse that includes CidrGuess
3 participants