Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jmap integration #10557

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Fix jmap integration #10557

merged 1 commit into from
Dec 26, 2024

Conversation

Thodor12
Copy link
Contributor

Closes discord report Journeymap no longer seems to be working

Changes proposed in this pull request

  • Removed a SubscribeEvent annotation, this caused Neoforge to assume the method was a Neoforge event handler, throwing an exception because the parameter wasn't an Event class. This was a silent exception caused during the Jmap plugin load, causing the plugin not to start.

Testing

  • Yes I tested this before submitting it.
  • I also did a multiplayer test.

Review please

@Raycoms
Copy link
Contributor

Raycoms commented Dec 26, 2024

But is this still properly called?

@Thodor12
Copy link
Contributor Author

Yeah, I booted it up and made sure it works, and it does. In 1.20 it works too so that ain't the problem.

@Raycoms Raycoms merged commit 3ad79a5 into version/1.21 Dec 26, 2024
5 checks passed
@Raycoms Raycoms deleted the fix/jmap_integration branch December 26, 2024 11:25
@uecasm
Copy link
Contributor

uecasm commented Dec 26, 2024

It worked when we were using the shared event bus. It still seems weird that we've split that off; it's likely to confuse addon mod makers by not following conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants