Warehouse item capability is invalidated every tick leading to compatibility issues

[jpenilla]

Is there an existing issue for this?

• I have searched the existing issues.

Are you using the latest MineColonies Version?

• I am running the latest beta/release version of MineColonies for my Minecraft version.
  I am also running the latest versions of other mods that are part of my problem.

Did you check on the Wiki? or ask on Discord?

• I checked the MineColonies Wiki and made sure my issue is not covered there. Or I was sent from discord to open an issue here.

What were you playing at the time? Were you able to reproduce it in both settings?

• Single Player
• Multi Player

Minecraft Version

1.21

MineColonies Version

1.1.875

Structurize Version

1.0.758

Related Mods and their Versions

AE2 latest master and 1.21.1 release

Current Behavior

The item handler capability for the warehouse block is invalidated and recreated every tick, which causes strange compatibility issues with other mods interacting with the inventory.

For example, when connecting a warehouse to an AE2 network using a storage bus, insert and extract operations will sporadically fail or succeed seemingly randomly, with export buses, interfaces, and player interactions behaving differently.

This is because whether the operation succeeds depends on the ordering of the capability invalidation relative to the operation (which is semi-random). I noticed this bug on a server when export buses would not work but inserting and extracting from a terminal would, and then later inserting from the terminal stopped working, and later reproduced it in a singleplayer world with a debugger attached. See the screenshots below for the two calls that happen each tick

Most other mods besides AE2 seem to work fine (i.e. MI pipes), however, depending on where in the tick loop they operate this problem could affect other mods too.

Expected Behavior

Capability is invalidated only when necessary, AE2 storage bus works normally.

Reproduction Steps

Attach an AE2 storage bus to a warehouse block and attempt to insert/extract items with terminals, import buses, export buses, interfaces, etc., and observe inconsistent and broken behavior.

Logs

https://mclo.gs/smM7B6a

Anything else?

No response

Footer

---

Viewers

• Add a thumbs-up to the bug report if you are also affected. This helps the bug report become more visible to the team and doesn't clutter the comments.
• Add a comment if you have any insights or background information that isn't already part of the conversation.