-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request system/clipboard bug #10497
Comments
A client on our server is having a similar crash. I can get you server logs if you want them. |
We did a request system reset. Things worked after that until log out. |
Is there any serverside log that appears shortly before that? |
I'll ask the owner for it. |
This is an error while server is starting (part of server logs) |
okay, that is also a symptom of the same thing. There must be an error somewhat earlier causing it. |
Server logs for the 4th and 5th of December. Player reported issues on the 5th. https://gist.github.com/kezmodius/b30d44564b96748938da0273d5e90f53 |
Odd, logs have nothing out of the ordinary. Were mods removed or so? |
In my case, nothing was deleted. I'm still playing with the "Minecolonies: Dimensional Adventure 2.1.6" modpack. Updates don't bring any results. The request system started to break down after a few days of playing (maybe even a week or two). |
Yeah, something corrutps the request system on the serverside which causes issues on the client then. If you can do a request system reset. and then upload the serverside log the moment things break again, that would be great. |
I just changed the "colonyloadstrictness" setting to 1 in minecolonies-server.toml and it seems to have fixed the problem. The request system has been working fine for a while now. My colony is very large and it is possible that some chunks were not loading. It is possible that this is a coincidence, but I think it is worth mentioning. |
An unloaded building can cause issues indeed. But a log would still be great to be able to check this out =D |
I restarted the request system at 19:38 and it worked the whole time. Now it started breaking again since the message "Handling Survival Placement in Colony" appeared https://gist.github.com/Detruo/5275f5ba841d6397c80a5463fbe3e7bb I get an error on the client every second: |
Here is more information for the ongoing issue with the clipboard. It's only one colony, but it's anyone in the colony - both the player who owns it, and me (server admin) added as officer. At this point his colony is unplayable, but I'm unsure whether the best course of action is to update the server (which has nearly 60 semi-active players who will need to update their modpacks) or have him restart his colony, since it's ONLY his colony where this is happening. Attached are the server latest.log, my client latest.log, and the colony export, just after the issue happened for me and the request system was reset. |
I updated our test server to 771 and it's still happening. |
There's an error even when not in the colony. |
Yes, this error is quite clear, it's actually loaded from file. I wonder if there is an error before this occurs. |
How could I find that? |
Do a request system reset, wait until you see the error in the log. Send me the error that spans over this time (I couldn't find the reset in the previois log) |
Started both server and client, reset the request system, clipboard worked (showed ancient tome and smeltable ore) then broke. Shut down server and pulled both logs. |
Can you check if there is a crafter that has a recipe that either has air as input, or output? |
Could it also be a request for a minimum stock of air? I might have seen one of those in my colony. |
Yes, minimum stock is similarily possible |
I couldn't find any of those instances (unfortunately?). So I guess my issue is caused by something else, less I missed a crafter/builder. The closest oddity I got is a courier who seems to be hired at two workshops at once and at the same time non of them. Ie the workers tab in both warehouses lists his name but when pressing "Manage workers" his name is missing. Considering couriers part in the request system I guss it could be connected? |
Hii! |
Can you update to latest and keep me updated? |
@AnyankaT said that even in the latest update (771) on the test server was still having this bug |
It has not been solve yet in 1.1.772, but the logging has been improved in that version, which can help Ray find out what the actual issue is |
Yes, please send me the newest server & client logs |
I updated the mod to version 773. I started the server and restarted request system. After a while I started getting errors in the client logs, but the requests were still visible on the clipboard. I also noticed after a while that Cowhand was requesting 128 of Air - exactly the same amount as I set him to milk cows during the day. The minimum Stock is not set for him. |
Same thing happening here. I updated to 774. Cowhand was requesting 1000 air, same as the milk attempts that were set. It's interesting to note that the clipboard did not bug out this time. I cancelled the request for air, but it did return. |
This is very weird. It recognizes it as a bottle request, because it's resolved correctly, but it's still air? |
Nvm, the problem is on the client, on the server the data is correctly actually |
Do you have any datapacks on the client that might be messing with the bottles? |
Not that I'm aware of, but I will go back through and check our data packs.
Michelle Smith
Independent Language Trainer
…On Thu, Dec 12, 2024 at 22:27 Raycoms ***@***.***> wrote:
Do you have any datapacks on the client that might be messing with the
bottles?
—
Reply to this email directly, view it on GitHub
<#10497 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6MD2VJ5F57HIYNOWRJXI3L2FH5TBAVCNFSM6AAAAABS2ES2XOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBQGA2DKNBVGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No, there are no datapacks in our modpack that touch the bottle recipes. The player is using our pack as-is with no additions. |
Is there an existing issue for this?
Are you using the latest MineColonies Version?
I am also running the latest versions of other mods that are part of my problem.
Did you check on the Wiki? or ask on Discord?
What were you playing at the time? Were you able to reproduce it in both settings?
Minecraft Version
1.20
MineColonies Version
1.20.1-1.1.760
Structurize Version
1.20.1-1.0.760
Related Mods and their Versions
Current Behavior
After some time clipboard stopped showing NPC requests. The command "/mc colony requestsystem-reset-all" sometimes works but for a few seconds. Sometimes when tries to add an NPC custom recipe via request or I open the clipboard and it crashes the game. When I want to request something via Postbox, the request doesn't appear on the right side, but the NPC still brings the requested items.
Expected Behavior
X
Reproduction Steps
X
Logs
https://gist.github.com/Detruo/df5d47d16314d8d13c79a48676d86785
Anything else?
No response
Footer
Viewers
The text was updated successfully, but these errors were encountered: