Fix cmake bug when ldc is a submodule #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow ldc to be a submodule. This uses changes from https://github.com/rpavlik/cmake-modules. (cherry picked from commit 0be5ead)
|
Looks like Travis failures are something unrelated to this change. A test taking too long and getting killed? |
redstar
added a commit
that referenced
this pull request
Mar 15, 2015
Fix cmake bug when ldc is a submodule
|
Yes, |
|
Thanks Kai! By the way, are the "cherry picked ..." messages in the topic branch commit useful or just noise, or a don't care? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a cmake error that can happen when ldc is included as a git submodule.
The change is a selection of updates from a more recent version of GetGitRevisionDescription.cmake at https://github.com/rpavlik/cmake-modules.
Note for error verification - the error doesn't happen if there is a tag on the submodule commit.