Get rid of cycles in DtoType() #4736
Merged
+99
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinke
force-pushed
the
fix4734
branch
4 times, most recently
from
34c353d
to
530e9de
Compare
kinke
changed the title
To break remaining cycles in DtoType() - a class *ref* is an opaque IR pointer nowadays.
|
|
||
| if (getTypeAllocSize(t->type) != sd->structsize) { | ||
| error(sd->loc, "ICE: struct IR size does not match the frontend size"); | ||
| fatal(); |
There was a problem hiding this comment.
I presume this errors for the testcase of #4734 ? (without the fix of this PR)
There was a problem hiding this comment.
Yes, at least without assertions (I've checked the vanilla-LLVM jobs), I think those were hit earlier.
JohanEngelen
pushed a commit
to weka/ldc
that referenced
this pull request
Aug 20, 2024
Get rid of cycles in DtoType() Merge pull request ldc-developers#4712 from kinke/bump_ldc_llvm Bump LDC-LLVM to v18.1.8 Revert "Merge pull request ldc-developers#4736 from kinke/fix4734" This reverts commit 53dc56a73f0704bee6fc5db82bae5e0d0b98f82b.
|
Tested at Symmetry (hence the beta2 release - not requiring a fork any longer), looking good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the nice side-effect of fixing #4734.