Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump LDC-LLVM to v18.1.5 #4642

Merged
merged 1 commit into from
May 10, 2024
Merged

Bump LDC-LLVM to v18.1.5 #4642

merged 1 commit into from
May 10, 2024

Conversation

kinke
Copy link
Member

@kinke kinke commented May 4, 2024

No description provided.

@kinke kinke changed the title Bump LDC-LLVM to v18.1.5 Bump LDC-LLVM to v18.1.5 (incl. macOS arm64) May 4, 2024
# FIXME: disabling LTO for C++ parts as well as PGO, out of caution due to
# weird issues for native job experiments in https://github.com/ldc-developers/ldc/pull/4604
# -DEXTRA_CXXFLAGS=-flto=full
#with_pgo: true
Copy link
Member Author

@kinke kinke May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JohanEngelen: This is pretty much shooting in the dark from my side. ;) - The problem is that the current prebuilt macOS arm64 package cannot be used for cross-compiling to Android, as its LDC-LLVM 17 emulates TLS, while druntime expects no TLS emulation.

So no idea whether this might cause random 'pure virtual function called' crashes now with the natively compiled LLVM 18, whether that has already been the case before for our current cross-compiled artifacts, or whether that is related to Xcode 15, or using a native host compiler (with e.g. 64-bit compile-time real_t), ...

What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry I have been putting off looking in detail at the pure virtual function called error. I'll see if I can reproduce it this weekend.

@kinke kinke changed the title Bump LDC-LLVM to v18.1.5 (incl. macOS arm64) Bump LDC-LLVM to v18.1.5 May 10, 2024
@kinke kinke enabled auto-merge (squash) May 10, 2024 18:08
@kinke kinke merged commit 0bd8ea2 into ldc-developers:master May 10, 2024
23 checks passed
@kinke kinke deleted the llvm_18.1.5 branch May 10, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants