CI: Bump LDC-LLVM to v12.0.0 #3701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinke
force-pushed
the
llvm12
branch
3 times, most recently
from
cb43af4
to
8c154a5
Compare
kinke
force-pushed
the
llvm12
branch
2 times, most recently
from
8dd690a
to
c8a62e5
Compare
|
Remaining failures:
|
Including bumping the Ubuntu base image from 16.04 to 18.04.
JohanEngelen
reviewed
Jun 4, 2021
tests/PGO/indirect_calls.d
Outdated
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| // REQUIRES: PGO_RT | |||
|
|
|||
| // PROFUSE IR matching has regressed on Windows since LLVM 12 (due to our manual @weak emulation?) | |||
There was a problem hiding this comment.
Does it work if you remove @weak and add inline asm noop or something else that prevents the optimizer from knowing what the function does?
There was a problem hiding this comment.
Oh yeah, asm {} makes it work. 👍
As the PROFUSE IR matching has regressed on Windows with LLVM 12, apparently related to `@weak`.
As this trips up the optimized std.conv unittests on 32-bit x86 since LLVM 12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including bumping the Ubuntu base image from 16.04 to 18.04.