Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade frontend & libs to v2.091.0 #3333

Merged
merged 19 commits into from
Mar 8, 2020
Merged

Conversation

kinke
Copy link
Member

@kinke kinke commented Feb 21, 2020

No description provided.

@kinke
Copy link
Member Author

kinke commented Feb 21, 2020

Something bad must have happened wrt. static if and semantic analysis order or so:

core/stdc/math.d(4573): Error: undefined identifier `c_long`

when compiling core.stdc.config separately for non-Windows targets, which defines the c_long alias itself. It works when replacing the Posix-specific static if (https://github.com/dlang/druntime/blob/f80a07e1a0140f01878a4b13e2eea61faf6a3063/src/core/stdc/config.d#L118) by version (D_LP64).

@kinke
Copy link
Member Author

kinke commented Mar 6, 2020

Found a workaround for the c_long issue (localized import). The issue isn't new, e.g., LDC v1.20 also fails to compile core.stdc.config for Posix when importing core.math in core.internal.convert. The new global import was also a problem for neither-Windows-nor-Posix targets (wasm, Android...) because core.stdc.config.c_long isn't defined for those (but required in core.stdc.math...). It's LDC-specific because some core.math intrinsics are actually aliases to core.stdc.math symbols...

@kinke
Copy link
Member Author

kinke commented Mar 7, 2020

The only remaining problem is the ltsmaster compilability regression due to modernized contract syntax.

@kinke kinke force-pushed the merge-2.091 branch 2 times, most recently from 0e56e48 to f7d0e36 Compare March 7, 2020 15:43
Instead of `do` introduced with 2.075. We don't enable deprecations when
building the compiler, so it doesn't really matter.
Conflicts:
	CMakeLists.txt
@kinke
Copy link
Member Author

kinke commented Mar 7, 2020

We're now at a stage where ltsmaster apparently miscompiles the compiler, so that new ownership-borrow tests cause LDC segfaults if compiled with ltsmaster (Travis job): compilable/ob1.d, fail_compilation/fob{1,2}.d.

@kinke kinke changed the title [WIP] Upgrade frontend & libs to v2.091.0 Upgrade frontend & libs to v2.091.0 Mar 7, 2020
@kinke kinke mentioned this pull request Mar 8, 2020
@kinke kinke merged commit 5e626ce into ldc-developers:master Mar 8, 2020
@kinke kinke deleted the merge-2.091 branch March 8, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant