Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v2.081.2 #2815

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Merge v2.081.2 #2815

merged 2 commits into from
Aug 13, 2018

Conversation

kinke
Copy link
Member

@kinke kinke commented Aug 13, 2018

No description provided.

@kinke
Copy link
Member Author

kinke commented Aug 13, 2018

@joakim-noah: Please advance the submodule hashes here when cherry-picking druntime/Phobos stuff. For testing, but also visibility; where do the (quite invasive) Phobos changes come from, and have they been reviewed?

@kinke
Copy link
Member Author

kinke commented Aug 13, 2018

Ah, cherry-pick of (merged) dlang/phobos#6633.

@joakim-noah
Copy link
Contributor

joakim-noah commented Aug 13, 2018

I usually don't bother updating the submodule hashes, because I figure somebody else will for their own commits eventually and I'm in no hurry. My stdlib changes are almost never tested by the ldc CI anyway, since they're for Android, ARM and AArch64 (though that now changes with the new AArch64 Shippable CI). I only cherry-pick commits that've been approved upstream and tested locally, so shouldn't be a problem. If they're ldc-specific, I submit a pull here.

@kinke
Copy link
Member Author

kinke commented Aug 13, 2018

I usually don't bother updating the submodule hashes, because I figure somebody else will for their own commits eventually

I know, 'cause it's almost always me. ;) Please do bother, as changes may get temporarily lost until someone else trying to branch off ldc (as opposed to just the latest submodule hash) eventually notices that things are out of sync. It's also helpful when generating the change log.

@joakim-noah
Copy link
Contributor

Sure, will do.

@kinke kinke merged commit 1704ce6 into ldc-developers:master Aug 13, 2018
@kinke kinke deleted the merge-2.081 branch August 13, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants