Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch back to utf8 for LCache tables #149

Merged
merged 2 commits into from
Oct 3, 2017
Merged

Switch back to utf8 for LCache tables #149

merged 2 commits into from
Oct 3, 2017

Conversation

danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Sep 29, 2017 •
edited
Loading

Because our value column is longtext, utf8mb4 isn't necessary for
storing unicode characters.

See #148

@danielbachhuber
Switch back to utf8 for LCache tables
ef70315 
Because our `value` column is `longtext`, `utf8mb4` isn't necessary for
storing unicode characters.
@danielbachhuber
Bump working version to 0.6.1-alpha
6a6c3e1
@davidstrauss
Copy link
Member

This sounds reasonable to me, though I'm not sure of the benefit if there aren't any indexes on the value column.

@danielbachhuber
Copy link
Member Author

though I'm not sure of the benefit if there aren't any indexes on the value column.

The value column was the original motivation for utf8mb4, but the change also applied to the address column (which is included in an index).

@danielbachhuber danielbachhuber added this to the 0.6.1 milestone Oct 3, 2017
@danielbachhuber danielbachhuber merged commit bd35672 into master Oct 3, 2017
@danielbachhuber danielbachhuber deleted the 148-utf8 branch October 3, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbachhuber @davidstrauss