Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support utf8mb4 #131

Merged
merged 4 commits into from
May 12, 2017
Merged

Conversation

frankiejarrett
Copy link
Contributor

@frankiejarrett frankiejarrett commented May 9, 2017

Note
The schema for the tag and address in the tags table also had to be updated to varchar(191) to support utf8mb4 which can have up to 4 bytes per character ( 191 x 4 = 767 ) and therefore would result in an error upon table creation when using InnoDB since they are both primary keys:

WordPress database error Specified key was too long; max key length is 767 bytes.

cf.
https://developer.wordpress.org/reference/classes/wpdb/determine_charset/
https://developer.wordpress.org/reference/classes/wpdb/get_charset_collate/

@danielbachhuber danielbachhuber added this to the 0.5.3 milestone May 10, 2017
@danielbachhuber
Copy link
Member

Do we need an upgrade path for existing tables, or will existing tables continue to work as expected?

@frankiejarrett
Copy link
Contributor Author

@danielbachhuber It continues to work in my testing so far using utf8mb4 in the DSN even though the lcache tables are still utf8. But IMO a proper migration would be safest route.

I could steal the migration path from #124 and bring it in here, leaving out the removal of the lcache_tags table. Thoughts?

@danielbachhuber
Copy link
Member

I could steal the migration path from #124 and bring it in here, leaving out the removal of the lcache_tags table. Thoughts?

I don't think it's necessary at this point. We can revisit when we take on #123 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants