Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiSet consistent methods, Array setAll, MutableCollection popRandom #27

Merged
merged 14 commits into from
Mar 30, 2023
Merged

MultiSet consistent methods, Array setAll, MutableCollection popRandom #27

merged 14 commits into from
Mar 30, 2023

Conversation

lbressler13
Copy link
Owner

What was changed?

  • Update MultiSet + MutableMultiSet to implement Collection instead of Set
  • Default MultiSet plus/minus/intersect
  • MultiSet consistent methods
  • Array setAll methods
  • MutableCollection popRandom
  • Deprecation warnings on references in classes package

Checks

  • New and existing unit tests pass with my changes
  • Unit tests have been written for all new and changed functions
  • Comments have been added to hard-to-understand code
  • Docstrings have been updated with any modified function signatures
  • ktlint has run successfully
  • The version number has been updated if necessary

How was this tested?

Unit tests. Many of them

Additional Comments

Reason for major update: Changing MultiSet to Collection could be a breaking change

@lbressler13 lbressler13 changed the title Package v1.0.0 MultiSet consistent methods, Array setAll, MutableCollection popRandom Mar 16, 2023
@lbressler13 lbressler13 merged commit 741dac1 into main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
MAJOR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lbressler13