Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add country page layout #30

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Conversation

AlexeyTeterin
Copy link
Collaborator

No description provided.

@Tonia-SE Tonia-SE requested review from Tonia-SE and removed request for Tonia-SE March 17, 2021 10:21
@lbratkovskaya lbratkovskaya self-requested a review March 17, 2021 10:56
{props.url && (
<ReactPlayer
playing={false}
width="100%"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне кажется, безопаснее будет сделать тут чуть меньше 100%

import rootConnector, { rootProps } from '../../store/rootConnector';
import { Country, Sight, URLParamTypes } from '../../types';
import { IAppState } from '../../store/types';
import Map from '../Map';
// import Map from '../Map';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Комментарий уберём?

@@ -1,6 +1,6 @@
.MapContainer {
position: relative;
width: 80%;
width: 100%;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И тут я бы вернула процент меньше 100

@AlexeyTeterin AlexeyTeterin merged commit aab164b into develop Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants