Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Error in CommandGuard #175

Closed
StephanSchwarz96 opened this issue May 14, 2024 · 4 comments
Closed

Potential Error in CommandGuard #175

StephanSchwarz96 opened this issue May 14, 2024 · 4 comments
Assignees
Labels
bug Something isn't working high_priority

Comments

@StephanSchwarz96
Copy link

Hello everyone,

I recently run into some issues with the received robot state data which lead me to digging into the lbr_fri_ros2 package. I am not sure, but i might found an error within the code in command_guard.cpp in line 53:

for (std::size_t i = 0; i < lbr_command.joint_position[i]; ++i) {

Unlike the other checks (for position or torque limits), this does not iterate over the size() but the value, which in my case always stops after the first iteration since my joint_1 was lower than 1. Am I missing something here?

Thanks for feedback :)

@mhubii
Copy link
Member

mhubii commented May 14, 2024

oh this looks fishy :O, where in the code can this be found?

@mhubii mhubii added high_priority bug Something isn't working labels May 14, 2024
@mhubii
Copy link
Member

mhubii commented May 14, 2024

thank you so much for sharing this @StephanSchwarz96 . This is now fixed, please pull the changes.

There are some changes on the way, which will make this system a bit more capable.

@mhubii mhubii mentioned this issue May 14, 2024
34 tasks
@mhubii mhubii self-assigned this May 14, 2024
@mhubii
Copy link
Member

mhubii commented May 15, 2024

closing this for now as resolved. Thank you again very much! Please feel free to reach out if you have any questions / re-open the issue etc

@mhubii mhubii closed this as completed May 15, 2024
@mhubii mhubii mentioned this issue May 15, 2024
36 tasks
mhubii added a commit that referenced this issue May 17, 2024
@mhubii
Copy link
Member

mhubii commented May 17, 2024

hi @StephanSchwarz96 , this should now be fully resolved. Let me know if you have any other questions

If you could give some feedback on whether it works well now, that would be awesome, too!

@mhubii mhubii mentioned this issue Jun 11, 2024
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high_priority
Projects
None yet
Development

No branches or pull requests

2 participants