Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker #149

Closed
mhubii opened this issue Jan 18, 2024 · 3 comments
Closed

Docker #149

mhubii opened this issue Jan 18, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mhubii
Copy link
Member

mhubii commented Jan 18, 2024

Provide a docker file, refer @Nicolai-98 in #1 (comment)_
@mhubii mhubii mentioned this issue Jan 18, 2024
Closed
@mhubii mhubii added enhancement New feature or request good first issue Good for newcomers labels Jan 18, 2024
@Nicolai-98
Copy link
Contributor

Sure, I can do that. I will clean it up a bit first. You can expect a pull request tomorrow. In addition to the Dockerfile, I also have some scripts for building/launching and creating a new terminal within the Docker container. Would you like me to include them?

@mhubii
Copy link
Member Author

mhubii commented Jan 18, 2024 •
edited
Loading

yes that would be great, you can just create a pull request against dev-humble-docker branch and then we can iterate on it.

But no hurry at all, really appreciate the help!

Nicolai-98 added a commit to Nicolai-98/lbr_fri_ros2_stack that referenced this issue Jan 19, 2024
@Nicolai-98
lbr-stack#149 Added Dockerfile and scripts for building and running t…
52c8ee2 
…he container. Updated README.
mhubii added a commit that referenced this issue Jan 21, 2024
@mhubii
Merge pull request #150 from Nicolai-98/dev-humble-docker
4fa08f1 
#149 Added Dockerfile and scripts. Updated README.

thank you @Nicolai-98 for doing this so quickly!
@mhubii mhubii mentioned this issue Jan 21, 2024
Merged
@mhubii
Copy link
Member Author

mhubii commented Mar 4, 2024

done in #151

@mhubii mhubii closed this as completed Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhubii @Nicolai-98