New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the crash that occurs when the node's topLeft position is nan #234

Merged

lucdion merged 1 commit into layoutBox:master from OhKanghoon:fix-wrap-reverse-crash

Oct 15, 2023

Contributor

OhKanghoon commented Oct 14, 2023 •

edited

Loading

Background

fixes Crash occurs when a .wrapReverse flexbox container has a .display(.none) item. #233

Contents

replace point's nan value with zero

OhKanghoon changed the title ~~Fix Crash occurs when topLeft position is nan~~ Fix Crash occurs when node's topLeft position is nan

OhKanghoon changed the title ~~Fix Crash occurs when node's topLeft position is nan~~ Fix crash occurs when node's topLeft position is nan

OhKanghoon changed the title ~~Fix crash occurs when node's topLeft position is nan~~ Fix the crash that occurs when the node's topLeft position is nan


          fix: replacing nan with zero

b0c7067

OhKanghoon force-pushed the fix-wrap-reverse-crash branch from df1f3d6 to b0c7067 Compare

October 14, 2023 16:25

lucdion approved these changes

View reviewed changes

lucdion merged commit 8e082fa into layoutBox:master

1 check passed

Member

lucdion commented Oct 15, 2023

Thanks @OhKanghoon , a new release is available https://github.com/layoutBox/FlexLayout/releases/tag/2.0.03

OhKanghoon deleted the fix-wrap-reverse-crash branch

October 15, 2023 14:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet