Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update yoga core to v2.0 #230

Merged
merged 7 commits into from
Oct 1, 2023
Merged

Update yoga core to v2.0 #230

merged 7 commits into from
Oct 1, 2023

Conversation

OhKanghoon
Copy link
Contributor

@OhKanghoon OhKanghoon commented Sep 23, 2023 •
edited
Loading

Background

  • YogaKit has been removed from yoga official repository.
  • Update the yoga core to the most recent version of yoga 2.0, and manage YogaKit in FlexLayout from now on.
  • FlexLayout can later add 'gap' features added in yoga 2.0

@OhKanghoon OhKanghoon force-pushed the feature/yoga-2 branch 2 times, most recently from e60876c to 34231a6 Compare September 23, 2023 12:00
lucdion
lucdion reviewed Sep 23, 2023
View reviewed changes
Copy link
Member

@lucdion lucdion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OhKanghoon for this major update.
Please fix CI issues https://github.com/layoutBox/FlexLayout/actions/runs/6283516421/job/17064055867?pr=230 🙏

@OhKanghoon
Copy link
Contributor Author

Hi @lucdion

I usually work with spm so I missed the header setting of xcodeproj 😅
I fix ci in 6cc5128 commit, so you can check the commit

Facebook's YogaKit didn't fix it, but FlexLayout's YogaKit also reflected all the changes

@OhKanghoon OhKanghoon requested a review from lucdion September 26, 2023 03:07
@OhKanghoon
Copy link
Contributor Author

Hi @lucdion,

Could you please review my Pull Request when you have a moment?
It's been pending for a while, and your input would be really helpful.

Thanks!

@lucdion
Copy link
Member

lucdion commented Oct 1, 2023

Sorry @OhKanghoon , I wanted to take the time to check that is doesn't break anything important.
It looks good. I will switch FlexLayout version to 2.0 to match Yoga version

lucdion
lucdion approved these changes Oct 1, 2023
View reviewed changes
Copy link
Member

@lucdion lucdion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this important change @OhKanghoon 👏

@lucdion lucdion merged commit 52d47c1 into layoutBox:master Oct 1, 2023
1 check passed
lucdion added a commit that referenced this pull request Oct 1, 2023
@lucdion
Revert "Merge pull request #230 from OhKanghoon/feature/yoga-2"
d66ce2e 
This reverts commit 52d47c1, reversing
changes made to f318774.
@lucdion
Copy link
Member

lucdion commented Oct 1, 2023

FlexLayout 2.0.02 is available https://github.com/layoutBox/FlexLayout/releases/tag/2.0.02

Thanks again

@OhKanghoon OhKanghoon deleted the feature/yoga-2 branch October 2, 2023 17:08
@Skyline-23 Skyline-23 mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucdion lucdion lucdion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OhKanghoon @lucdion