Skip to content
This repository has been archived by the owner on Nov 20, 2019. It is now read-only.

fix(IDN): use INTL_IDNA_VARIANT_UTS46 for idn_* functions #20

Merged
merged 2 commits into from
Nov 18, 2017

Conversation

layershifter
Copy link
Owner

This PR:

  • adds PHP 7.2 to test matrix
  • as INTL_IDNA_VARIANT_2003 is deprecated in PHP 7.2, we use INTL_IDNA_VARIANT_UTS46 for idn_* functions if it's defined

@codecov-io
Copy link

codecov-io commented Nov 18, 2017

Codecov Report

Merging #20 into master will decrease coverage by 1.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #20      +/-   ##
============================================
- Coverage       100%   98.88%   -1.12%     
- Complexity       70       72       +2     
============================================
  Files             4        4              
  Lines           175      179       +4     
============================================
+ Hits            175      177       +2     
- Misses            0        2       +2
Impacted Files Coverage Δ Complexity Δ
src/IDN.php 87.5% <100%> (-12.5%) 8 <0> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c27974a...5a72923. Read the comment docs.

@layershifter layershifter merged commit e570f7a into master Nov 18, 2017
@layershifter layershifter deleted the fix/idn-php7.2 branch November 18, 2017 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants