breaking(Parser): make getSubdomains always return an array (#33)

breaking(Parser): make getSubdomains always return an array
layershifter · Sep 28, 2018 · 236bfa0 · 236bfa0
1 parent 34cb389
commit 236bfa0
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/Result.php b/src/Result.php
@@ -72,11 +72,11 @@ public function getSubdomain()
     /**
      * Return subdomains if they exist, example subdomain is "www.news", method will return array ['www', 'bbc'].
      *
-     * @return null|array
+     * @return array
      */
     public function getSubdomains()
     {
-        return null === $this->subdomain ? null : explode('.', $this->subdomain);
+        return null === $this->subdomain ? array() : explode('.', $this->subdomain);
     }
 
     /**

diff --git a/src/ResultInterface.php b/src/ResultInterface.php
@@ -35,7 +35,7 @@ public function getSubdomain();
     /**
      * Return subdomains if they exist, example subdomain is "www.news", method will return array ['www', 'bbc'].
      *
-     * @return null|array
+     * @return array
      */
     public function getSubdomains();
 

diff --git a/tests/ResultTest.php b/tests/ResultTest.php
@@ -78,7 +78,7 @@ public function testDomain()
 
         static::assertEquals('github.com', $result->getFullHost());
         static::assertEquals(null, $result->getSubdomain());
-        static::assertEquals(null, $result->getSubdomains());
+        static::assertEquals(array(), $result->getSubdomains());
         static::assertEquals('github.com', $result->getRegistrableDomain());
         static::assertTrue($result->isValidDomain());
         static::assertFalse($result->isIp());
@@ -136,7 +136,7 @@ public function testIp()
 
         static::assertEquals('192.168.0.1', $result->getFullHost());
         static::assertEquals(null, $result->getSubdomain());
-        static::assertEquals(null, $result->getSubdomains());
+        static::assertEquals(array(), $result->getSubdomains());
         static::assertNull($result->getRegistrableDomain());
         static::assertFalse($result->isValidDomain());
         static::assertTrue($result->isIp());