Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add termination time when creating servers. #76

Merged
merged 2 commits into from
May 16, 2023
Merged

Add termination time when creating servers. #76

merged 2 commits into from
May 16, 2023

Conversation

gyohuangxin
Copy link
Member

@gyohuangxin gyohuangxin commented May 13, 2023 •
edited
Loading

Description

This PR fixes #75

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@gyohuangxin
Add termination time when creating servers.
7aa2ee8 
Signed-off-by: Xin Huang <xin1.huang@intel.com>
@gyohuangxin gyohuangxin marked this pull request as ready for review May 15, 2023 13:20
vielmetti
vielmetti approved these changes May 15, 2023
View reviewed changes
Copy link

@vielmetti vielmetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should work. Worth noting that there isn't millisecond precision on the termination_time timestamp in practice, so

date --utc -d "110 minute" +"%FT%TZ"

should work equally well.

@gyohuangxin
Fix date format
712dcc1 
Signed-off-by: Huang Xin <xin1.huang@intel.com>
@gyohuangxin
Copy link
Member Author

@vielmetti Thanks, fixed in 712dcc1

@gyohuangxin gyohuangxin requested a review from leecalcote May 16, 2023 01:18
leecalcote
leecalcote approved these changes May 16, 2023
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful.

@leecalcote leecalcote merged commit 7e95e5a into layer5io:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vielmetti vielmetti vielmetti approved these changes

@leecalcote leecalcote leecalcote approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark test servers for auto-deletion using "end_at" parameter
3 participants
@gyohuangxin @vielmetti @leecalcote