Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add (de)serialization support for OKP key type #125

Merged
merged 4 commits into from
Jan 7, 2020
Merged

Add (de)serialization support for OKP key type #125

merged 4 commits into from
Jan 7, 2020

Conversation

akhilles
Copy link
Contributor

@akhilles akhilles commented Jan 3, 2020

Also refactored AlgorithmParameters::OctetKey to be more consistent with the other enum variants.

@lawliet89 lawliet89 self-requested a review January 3, 2020 02:56
@lawliet89 lawliet89 self-assigned this Jan 3, 2020
@lawliet89
Copy link
Owner

Thanks for your contribution. I will look over this today (Friday) if I have the time. If not, I'll look over it next week on Monday.

@lawliet89 lawliet89 added the breaking Fixing this will cause breaking changes label Jan 7, 2020
lawliet89
lawliet89 approved these changes Jan 7, 2020
View reviewed changes
Copy link
Owner

@lawliet89 lawliet89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have labelled this as "breaking" and I will make a minor version release in the future.

@lawliet89 lawliet89 merged commit 6162415 into lawliet89:master Jan 7, 2020
@lawliet89 lawliet89 added this to the v0.5.0 milestone Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lawliet89 lawliet89 lawliet89 approved these changes

Assignees

@lawliet89 lawliet89

Labels
breaking Fixing this will cause breaking changes
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@akhilles @lawliet89