JWKSet is not cloneable

[Eric-Arellano]

Hello, thank you for an excellent library! This has been really helpful and I appreciate the JWK support.

It looks like JWKSet does not derive Clone:

biscuit/src/jwk.rs

Lines 665 to 670 in 9148092

	/// A JSON object that represents a set of JWKs.
	#[derive(Debug, Eq, PartialEq, Serialize, Deserialize)]
	pub struct JWKSet<T> {
	/// Containted JWKs
	pub keys: Vec<JWK<T>>,
	}

However, JWK does:

biscuit/src/jwk.rs

Lines 616 to 630 in 9148092

	/// A JSON object that represents a cryptographic key.
	/// The members of the object represent properties of the key, including its value.
	/// Type `T` is a struct representing additional JWK properties
	#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
	pub struct JWK<T> {
	/// Common JWK parameters
	#[serde(flatten)]
	pub common: CommonParameters,
	/// Key algorithm specific parameters
	#[serde(flatten)]
	pub algorithm: AlgorithmParameters,
	/// Additional JWK parameters
	#[serde(flatten)]
	pub additional: T,
	}

Do you know if there is a particular reason for this, or it's only an oversight? I'd be happy to submit a small patch for 0.6.* if you'd be interested.

[lawliet89]

It's an oversight. Please submit a PR to add it in, if you have the time.

[lawliet89]

Had some time so I've opened and will merge in #204 once tests pass.

[Eric-Arellano]

Thank you!