Adjust Makefile for additional target lavad-protocol #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User must explicitly choose the target binaries, via the target(s)
or using env-var LAVA_BINARY:
{build,install}-lavad: build/install lavad
{build,install}-lava-protocol: build/intsall lava-protocol
{build,install}-all: build/install all binaries
{build,install}: build/install $LAVA_BINARY (in env; error if unset)
orenl-lava
force-pushed
the
makefile-fix-build-install
branch
from
b2a6dbe to
1bf4a1a
Compare
User must explicitly choose the target binaries, via the target(s)
or using env-var LAVA_BINARY:
{build,install}-lavad: build/install lavad
{build,install}-lava-protocol: build/intsall lava-protocol
{build,install}-all: build/install all binaries
{build,install}: build/install $LAVA_BINARY (in env; error if unset)
Also, adjust the target so it only runs if *.proto files changed. Also, change it so docker uses ephemeral containers (not permanent).
orenl-lava
force-pushed
the
makefile-fix-build-install
branch
from
c3072f0 to
45dbc8a
Compare
…into makefile-fix-build-install
…ding a short readme
orenl-lava
commented
Aug 10, 2023
ranlavanet
previously approved these changes
Aug 10, 2023
ranlavanet
previously approved these changes
Aug 10, 2023
omerlavanet
requested changes
Aug 13, 2023
omerlavanet
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User must explicitly choose the target binaries, via the target(s) or using env-var LAVA_BINARY:
{build,install}-lavad: build/install lavad
{build,install}-lava-protocol: build/intsall lava-protocol
{build,install}-all: build/install all binaries
{build,install}: build/install $LAVA_BINARY (in env; error if unset)