-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNS-496: fixation allow append after delete #660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed fixation to allow
AppendEntry()
afterDelEntry()
takes effect, with the following new rules:AppendEntry()
may add retroactive entry only if it does not precede an existing latest entry.AppendEntry()
may not add future entries on or beyond aDeletedAt
in the future.DeleteAt
is permitted but useless, because it will be deleted straight away).DelEntry()
discards all future entries on or beyond theDeletedAt
(and owing to the previous rule, none will be added until thy delete actually takes place).Also fix a few glitches in the previous code:
IsLatest
flagDeleteAt
superseded by maturing future entries incorrectly retained theirDeleteAt
AdvanceBlock()
for each block