CNS-385: project propagate charge of CU onward #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenl-lava
force-pushed
the
CNS-385-project-propagate-charge-cu
branch
from
987b666 to
87be59a
Compare
orenl-lava
force-pushed
the
CNS-381-timer-versioning-and-migration
branch
from
af72527 to
fbe2b87
Compare
orenl-lava
force-pushed
the
CNS-385-project-propagate-charge-cu
branch
2 times, most recently
from
0c36c1c to
c0baf28
Compare
orenl-lava
force-pushed
the
CNS-381-timer-versioning-and-migration
branch
from
fbe2b87 to
6c81d2c
Compare
Base automatically changed from
CNS-381-timer-versioning-and-migration
to
CNS-376-fixation-versioning-and-migration
April 23, 2023 07:53
Base automatically changed from
CNS-376-fixation-versioning-and-migration
to
main
April 24, 2023 10:55
orenl-lava
force-pushed
the
CNS-385-project-propagate-charge-cu
branch
3 times, most recently
from
65ee217 to
588f10d
Compare
FixationStore methods "ModifyEntry" and "PutEntry" always expect valid index/block arguments of an existing entry (as opposed to "FindEntry" which returns the entry with nearst-smaller block). Adjust their logic as needed and do not use the iterator in getUnmarshaledEntryForBlock(). Also introduce new method "ReadEntry" which reads/copies an existing entry by index/block.
Add method GetEntryVersionRange(ctx, index, block, ceiling), which returns list of block versions of an entry, starting from the nearest-smaller block and capped by ceiling. If block is 0 and ceiling is math.MaxUint64, then this gives all versions. If ceiling is block + STALE_ENTRY_TIME then this returns range of versions that are may belong in the same "snapshot" (e.g. for a project).
Charging CUs to a project always happens to a certain fixation version (by block). When doing so, the charge should propagate from that version onward: until the most recent version, or until a re-charged version (i.e. after subscription month end) is reached, as marked by a new snapshot.
orenl-lava
force-pushed
the
CNS-385-project-propagate-charge-cu
branch
from
588f10d to
ea131cb
Compare
Yaroms
requested changes
May 1, 2023
Yaroms
approved these changes
May 1, 2023
Yaroms
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charging CUs to a project always happens to a certain fixation version (by block).
When doing so, the charge should propagate from that version onward: until the
most recent version, or until a re-charged version (i.e. after subscription month
end) is reached, as marked by a new snapshot.