CNS-368: fixation store fix refcount and deletions #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixation entry refcount was half-baked: the latest entries had refcount 0, and the code had special handling to avoid ignoring/removing them; Fixed by adding proper refcount handling. Signed-off-by: Oren Laadan <orenl@lavanet.xyz>
Fix the garbage collection logic: 1) When entries get StaleAt field set, set a timer to fire on that block. 2) Whenever such timer fires, scan all versions of the respective index to remove eligible stale versions. 3) Here, "eligible" stale version is one whose preceding version is stale. The oldest version is always "eligible".
Now that FixationStore's requires AdvanceBlock() callback, make sure the current users of FixationStore call it.
orenl-lava
force-pushed
the
CNS-368-timer-store-introduce
branch
from
b57ccd7 to
c8956b6
Compare
orenl-lava
force-pushed
the
CNS-368-fixation-store-fix-refcount
branch
from
c349bf2 to
b62c1d9
Compare
oren-lava
previously requested changes
Apr 9, 2023
Yaroms
requested changes
Apr 10, 2023
Yaroms
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix refcount handling: FixationStore entry refcount was half-baked: the latest entries had refcount 0, and the code had special handling to avoid ignoring/removing them.
Fix garbage collection logic for stale entries: (1) When entries get StaleAt field set, set a timer to fire on that block; (2) Whenever such timer fires, scan all versions of the respective index to remove eligible stale versions ("eligible" stale version is one whose preceding version is stale; the oldest version is always "eligible").