CNS-352: Reset CU at month end #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenl-lava
force-pushed
the
CNS-352-reset-cu-at-month-end
branch
from
e193382 to
f6ea05b
Compare
Yaroms
requested changes
Apr 9, 2023
GetAllEntryIndicesWthPrefix() returns list of indices a given prefix. This is useful, for example, to get the list of projects of a subscription.
orenl-lava
force-pushed
the
CNS-352-reset-cu-at-month-end
branch
from
ed1ac44 to
bc092a9
Compare
Re-charge the subscription CU at the end of subscription's month, and also use project's snapshot functionality to re-charge the projects too. Signed-off-by: Oren Laadan <orenl@lavanet.xyz>
Signed-off-by: Oren Laadan <orenl@lavanet.xyz>
Signed-off-by: Oren Laadan <orenl@lavanet.xyz>
orenl-lava
force-pushed
the
CNS-352-reset-cu-at-month-end
branch
from
bc092a9 to
e9ca5c0
Compare
Yaroms
requested changes
Apr 10, 2023
Signed-off-by: Oren Laadan <orenl@lavanet.xyz>
Yaroms
approved these changes
Apr 16, 2023
Yaroms
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that subscriptions at the end of each month reset/recharge the CU usage of their projects. For this, we store (in the Projects module) the list of projects for each subscription.
The PR also fixes calls to DeleteProject() which used the bare project name, rather than the outcome of ProjectIndex() function (which combines the subscription address with the project name).
NOTE: this requires a store-migration to ensure that existing subscriptions get their projects tracked in the Projects module store.