CNS-337: e2e testing for subscription pairing #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenl-lava
force-pushed
the
CNS-337-e2e-subscription-pairing
branch
from
e88d626 to
5e02dfa
Compare
orenl-lava
force-pushed
the
CNS-337-e2e-subscription-pairing
branch
3 times, most recently
from
49cf839 to
6010421
Compare
orenl-lava
force-pushed
the
CNS-337-e2e-subscription-pairing
branch
3 times, most recently
from
b55e2b6 to
b8f5076
Compare
Yaroms
force-pushed
the
CNS-337-e2e-subscription-pairing
branch
from
f1eaf2a to
b8f5076
Compare
orenl-lava
force-pushed
the
CNS-337-e2e-subscription-pairing
branch
6 times, most recently
from
6b098c5 to
fcc3431
Compare
Signed-off-by: Oren Laadan <orenl@lavanet.xyz>
Introduce execCommand() helper for common code used in several functions.
Signed-off-by: Oren Laadan <orenl@lavanet.xyz>
Add tests that for a client with active subscription ("user3"), similar to the
tests with staked clients.
The e2e timeout was inconsistent: First, "go test" default timeout is 10 minutes, which it can be changed using "go test -timeout ...". However, the e2e test internally runs another "go test" without any argument, so even if the user specified a longer timeout for the test, the latter would fail within the default timeout. Second, in at least one place the timeout was hard-coded fixed to 10 minutes. This is fixed by settings the timeout the intenral "go test" to zero, and then insteead settings the context.WithTimeout to the timeout requested by the user.
Initially subscription testing was added on top of staked clients, so it doubled the (already long) test time. However, it's enough to test staked-clients on ETH1 and subscriptions on LAV1, as it still provides full coverage of the core functionalty (while each tests different access methods). Also generalize the code that invokes client tests so that it can handle multiple clients (currently up to 3, although we use only 1).
orenl-lava
force-pushed
the
CNS-337-e2e-subscription-pairing
branch
from
fcc3431 to
223e74c
Compare
Yaroms
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add plans proposal and subscription testing to E2E testing: