Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNS-313: Spec hierarchy reorganize #342

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Conversation

oren-lava
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • [ V ] Commit message follows the Contribution Guidelines
  • [ V ] Tests ran locally and added/modified if needed
  • [ V ] Docs have been added/updated, if applicable
  • [ V ] If applicable - JIRA ticket ID was added
  • What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
    spec update

  • What is the current behavior? (You can also link to an open issue here)
    specs import cosmos hub, fantom doesn't import eth, base import eth instead of optm

  • What is the new behavior (if this is a feature change)?
    specs import cosmos sdk (disabled spec that holds the default cosmos sdk APIs (cosmos hub might have custom APIs in the future so this separation needed to be done), fantom imports eth, base imports optm, lava spec includes plans queries

  • Please describe what manual tests you ran, if applicable

  • Other information:

@oren-lava oren-lava requested review from omerlavanet and Yaroms March 5, 2023 17:13
@oren-lava oren-lava changed the title Cns 313 hierarchy reorganize CNS-313: Spec hierarchy reorganize Mar 5, 2023
@SeanZoR
Copy link
Contributor

SeanZoR commented Mar 6, 2023

Thanks @oren-lava , this is how it look at this branch. LGTM.
chart (2)

@Yaroms Yaroms merged commit ac3238e into main Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants