Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add validation to the spec parameters #304

Merged
merged 1 commit into from
Feb 19, 2023
Merged

add validation to the spec parameters #304

merged 1 commit into from
Feb 19, 2023

Conversation

Yaroms
Copy link
Collaborator

@Yaroms Yaroms commented Feb 16, 2023

  • Please check if the PR fulfills these requirements
  • Commit message follows the Contribution Guidelines
  • Tests ran locally and added/modified if needed
  • Docs have been added/updated, if applicable
  • If applicable - JIRA ticket ID was added

  • What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Please describe what manual tests you ran, if applicable

  • Other information:

@Yaroms Yaroms requested a review from omerlavanet February 16, 2023 16:04
@omerlavanet omerlavanet merged commit e14d322 into main Feb 19, 2023
SeanZoR pushed a commit that referenced this pull request Feb 19, 2023
@Yaroms
add validation to the spec parameters (#304) (#310)
84a43f5 
Co-authored-by: Yaroms <103432884+Yaroms@users.noreply.github.com>
Co-authored-by: Yarom Swisa <yarom@lavanet.xyz git config --global user.name Yarom>
@Yaroms Yaroms deleted the CNS-spec-parameter-validation branch July 31, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omerlavanet omerlavanet omerlavanet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yaroms @omerlavanet