GROW-519 Update the relay latency calculation, Add guard shouldCountMetric #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… guard when storing the metrics to explude our internal tests.
tabakuj
changed the title
nirtayeb
reviewed
Feb 14, 2023
nirtayeb
reviewed
Feb 14, 2023
nirtayeb
reviewed
Feb 15, 2023
ranlavanet
requested changes
Feb 15, 2023
tabakuj
force-pushed
the
feature/update_relay_metrics
branch
from
9ae6f2f to
d8c7fd5
Compare
…metrics # Conflicts: # relayer/chainproxy/chainproxy.go # relayer/chainproxy/portalLogs.go
…etric for old portal and new one
# Conflicts: # relayer/chainproxy/chainproxy.go # relayer/chainproxy/grpc.go # relayer/chainproxy/jsonRPC.go # relayer/chainproxy/portalLogs.go # relayer/chainproxy/rest.go # relayer/chainproxy/tendermintRPC.go # relayer/metrics/metricsService.go
nirtayeb
reviewed
Feb 15, 2023
ranlavanet
requested changes
Feb 15, 2023
|
lgtm - @ranlavanet wdyt? |
ranlavanet
approved these changes
Feb 16, 2023
nirtayeb
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Please describe what manual tests you ran, if applicable
Other information: