Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNS-268: Implement Plans module #300

Merged
merged 58 commits into from
Mar 2, 2023
Merged

Conversation

oren-lava
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • [ V ] Commit message follows the Contribution Guidelines
  • [ V ] Tests ran locally and added/modified if needed
  • [ X ] Docs have been added/updated, if applicable
  • [ V ] If applicable - JIRA ticket ID was added
  • What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
    Feature (new module)

  • What is the current behavior? (You can also link to an open issue here)
    None

  • What is the new behavior (if this is a feature change)?
    The packages module's goal is to manage subscriptions packages in a similar way to the spec module. To create a buyable package, it must be proposed and voted in the network. Packages can be updated. Old versions of packages are removed after a given time (each package has a duration field for that). Additionally, I've implemented two queries for this module: show-all-packages and show-package-info, like the spec module.

The entryFixation library's goal is to create a standard set of APIs to manage fixated entities. The packages module uses the new entryFixation library.

  • Please describe what manual tests you ran, if applicable
    I've created a number of unit tests for the module, which all passed. I've checked that the module works correctly with a local node.

  • Other information:
    In the PR original submission, I didn't merge main yet to ease the code check. So the e2e tests might fail.

@oren-lava
Copy link
Collaborator Author

List of files that I've created/modified to review (meaning: without scaffolded files):

Packages module:
app/app.go
app/keepers/lavaKeepers.go
proto/packages/package.proto
proto/packages/package_unique_index.proto
proto/packages/package_versions_storage.proto
proto/packages/packages_add_proposal.proto
proto/packages/query.proto
testutil/keeper/keepers_init.go
testutil/keeper/packages.go
x/packages/client/cli/tx.go
x/packages/client/proposal_handler.go
x/packages/client/rest/rest.go
x/packages/client/utils/utils.go
x/packages/keeper/epoch_start.go
x/packages/keeper/grpc_query_show_all_packages.go
x/packages/keeper/grpc_query_show_package_info.go
x/packages/keeper/keeper.go
x/packages/proposal_handler.go
x/packages/types/addproposal.go
x/packages/types/errors.go
x/packages/types/expected_keepers.go
x/packages/types/proposal.go
x/packages/types/types.go

Entry Fixation library:
common/entryFixation.go
proto/common/entryFixation.proto

Other:
cookbook/package_json_example.json

cookbook/package_json_example.json Outdated Show resolved Hide resolved
proto/common/entryFixation.proto Outdated Show resolved Hide resolved
proto/common/entryFixation.proto Outdated Show resolved Hide resolved
common/entryFixation.go Outdated Show resolved Hide resolved
common/entryFixation.go Outdated Show resolved Hide resolved
x/packages/keeper/package_versions_storage.go Outdated Show resolved Hide resolved
proto/packages/package_versions_storage.proto Outdated Show resolved Hide resolved
x/packages/keeper/package_versions_storage.go Outdated Show resolved Hide resolved
x/packages/keeper/package_versions_storage.go Outdated Show resolved Hide resolved
x/packages/types/proposal.go Outdated Show resolved Hide resolved
@oren-lava oren-lava changed the title CNS-268: Implement Packages module CNS-268: Implement Plans module Feb 27, 2023
Yaroms
Yaroms previously approved these changes Feb 27, 2023
cookbook/plans/default.json Outdated Show resolved Hide resolved
cookbook/plans/default.json Outdated Show resolved Hide resolved
cookbook/plans/default.json Outdated Show resolved Hide resolved
cookbook/plans/default.json Outdated Show resolved Hide resolved
proto/plans/query.proto Show resolved Hide resolved
scripts/upgrade/upgrade_a_running_module.sh Outdated Show resolved Hide resolved
proto/plans/plan.proto Show resolved Hide resolved
cookbook/plans/default.json Outdated Show resolved Hide resolved
cookbook/plans/default.json Outdated Show resolved Hide resolved
x/plans/keeper/grpc_query_show_all_plans.go Outdated Show resolved Hide resolved
x/plans/keeper/grpc_query_show_all_plans.go Outdated Show resolved Hide resolved
x/plans/types/plan.go Show resolved Hide resolved
x/plans/types/plan.go Outdated Show resolved Hide resolved
x/plans/keeper/plan.go Show resolved Hide resolved
x/plans/keeper/plan_test.go Outdated Show resolved Hide resolved
x/plans/keeper/plan_test.go Show resolved Hide resolved
@oren-lava oren-lava requested review from orenl-lava and Yaroms March 2, 2023 10:40
Yaroms
Yaroms previously approved these changes Mar 2, 2023
common/fixation_entry.go Outdated Show resolved Hide resolved
@oren-lava oren-lava requested a review from Yaroms March 2, 2023 14:35
@Yaroms Yaroms merged commit 7d0c406 into main Mar 2, 2023
@Yaroms Yaroms deleted the CNS-268-implement-package-module branch July 31, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants