-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNS-268: Implement Plans module #300
Conversation
… accordingly (added in packages module unique index list)
List of files that I've created/modified to review (meaning: without scaffolded files): Packages module: Entry Fixation library: Other: |
What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
Feature (new module)
What is the current behavior? (You can also link to an open issue here)
None
What is the new behavior (if this is a feature change)?
The packages module's goal is to manage subscriptions packages in a similar way to the spec module. To create a buyable package, it must be proposed and voted in the network. Packages can be updated. Old versions of packages are removed after a given time (each package has a duration field for that). Additionally, I've implemented two queries for this module: show-all-packages and show-package-info, like the spec module.
The entryFixation library's goal is to create a standard set of APIs to manage fixated entities. The packages module uses the new entryFixation library.
Please describe what manual tests you ran, if applicable
I've created a number of unit tests for the module, which all passed. I've checked that the module works correctly with a local node.
Other information:
In the PR original submission, I didn't merge main yet to ease the code check. So the e2e tests might fail.