Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRT-XYZ Fix invalid parsing and add unit tests #298

Merged
merged 9 commits into from
Feb 14, 2023
Merged

PRT-XYZ Fix invalid parsing and add unit tests #298

merged 9 commits into from
Feb 14, 2023

Conversation

0xAleksaOpacic
Copy link
Contributor

@0xAleksaOpacic 0xAleksaOpacic commented Feb 8, 2023 •
edited
Loading

  • Please check if the PR fulfills these requirements
  • Commit message follows the Contribution Guidelines
  • Tests ran locally and added/modified if needed
  • Docs have been added/updated, if applicable
  • If applicable - JIRA ticket ID was added
  • What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)

Bug Fix

  • What is the current behavior? (You can also link to an open issue here)

The response error data is not JSON compatible so clients can not unmarshal objects

  • What is the new behavior (if this is a feature change)?

fix the issue so the error data is json compatible

  • Please describe what manual tests you ran, if applicable

  • Other information:

omerlavanet
omerlavanet requested changes Feb 12, 2023
View reviewed changes
protocol/common/rpcconsumerlogs.go Outdated Show resolved Hide resolved
@ranlavanet ranlavanet changed the title Fix invalid parsing and add unit tests PRT-XYZ Fix invalid parsing and add unit tests Feb 12, 2023
@ranlavanet ranlavanet self-requested a review February 13, 2023 17:57
ranlavanet
ranlavanet previously approved these changes Feb 13, 2023
View reviewed changes
omerlavanet
omerlavanet previously approved these changes Feb 14, 2023
View reviewed changes
@ranlavanet ranlavanet dismissed stale reviews from omerlavanet and themself via 03efcd1 February 14, 2023 13:28
@ranlavanet ranlavanet merged commit 2f6bd38 into main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranlavanet ranlavanet ranlavanet approved these changes

@omerlavanet omerlavanet omerlavanet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xAleksaOpacic @omerlavanet @ranlavanet