Cns 266 remove core.block and use instead blockhash that is saved in storage #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2023 00:55
omerlavanet
requested changes
Feb 2, 2023
omerlavanet
previously approved these changes
Feb 2, 2023
omerlavanet
approved these changes
Feb 2, 2023
Yaroms
deleted the
CNS-266-consensus-failure-need-to-remove-the-usage-of-core-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a bug fix, removing core.block from pairing as it is not determinitic
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Please describe what manual tests you ran, if applicable
Other information: