Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNS-252: Added chain ID and enabled API interfaces to show-all-chains output #267

Merged
merged 6 commits into from
Jan 30, 2023

Conversation

oren-lava
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • [ V ] Commit message follows the Contribution Guidelines
  • [ V ] Tests ran locally and added/modified if needed
  • [ V ] Docs have been added/updated, if applicable
  • [ V ] If applicable - JIRA ticket ID was added
  • What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    The show-all-chains query outputs the full names of all the supported chains.

  • What is the new behavior (if this is a feature change)?
    The show-all-chains query outputs the full names of all the supported chains AND their IDs and enabled API interfaces (like REST, jsonrpc, etc.)

  • Please describe what manual tests you ran, if applicable

  • Other information:

proto/spec/query.proto Outdated Show resolved Hide resolved
x/spec/keeper/grpc_query_show_all_chains.go Outdated Show resolved Hide resolved
x/spec/keeper/grpc_query_show_all_chains.go Outdated Show resolved Hide resolved
Yaroms
Yaroms previously approved these changes Jan 26, 2023
Yaroms
Yaroms previously approved these changes Jan 27, 2023
@Yaroms Yaroms requested review from omerlavanet and removed request for omerlavanet January 27, 2023 10:57
@oren-lava oren-lava requested a review from omerlavanet January 29, 2023 09:58
@Yaroms Yaroms merged commit 9d04df7 into main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants