-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNS-137: implement new jailing design #238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the unresponsive stress test is very slow, so we might omit it after we get the timing results (its goal is to test how much time the unresponsive provider check takes, since it happens every epoch) |
…it won't be too slow)
Yaroms
requested changes
Jan 17, 2023
Yaroms
requested changes
Jan 18, 2023
Yaroms
requested changes
Jan 19, 2023
Yaroms
requested changes
Feb 2, 2023
Yaroms
previously approved these changes
Feb 2, 2023
Yaroms
previously approved these changes
Feb 2, 2023
…llectPayment param
Yaroms
previously approved these changes
Feb 5, 2023
omerlavanet
requested changes
Feb 5, 2023
omerlavanet
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, unit tests, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
Every consumer can report a provider as unresponsive. If a provider has enough complaints, he's punished (unstaked).
What is the new behavior (if this is a feature change)?
The problem with the current behavior is that a group of very small consumers could potentially take down a large provider. The new design punishes providers in correlation with the CU they serviced.
To check whether a provider should be punished (jailed/unstaked), we compare the CU serviced by the provider to the used CU of the complainers (the CU that would have used with this provider, but couldn't since he was unresponsive). Only if the complainers' CU is larger than the provider's serviced CU, the provider gets punished.
Please describe what manual tests you ran, if applicable
I've modified the current unresponsive unit tests and added sort of a stress test to measure the amount of time the check for unresponsive providers (and punishment) takes
Other information: