fix: audit fixes #1672
Open
fix: audit fixes #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results2 204 tests - 1 2 204 ✅ - 1 24m 22s ⏱️ - 1m 0s Results for commit 9218823. ± Comparison against base commit 6278d1a. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
Yaroms
reviewed
Sep 10, 2024
Yaroms
reviewed
Sep 10, 2024
Yaroms
reviewed
Sep 10, 2024
Yaroms
reviewed
Sep 10, 2024
Yaroms
reviewed
Sep 10, 2024
Yaroms
previously approved these changes
Sep 16, 2024
omerlavanet
previously approved these changes
Sep 16, 2024
| @@ -14,6 +14,8 @@ import ( | |||
| "golang.org/x/exp/slices" | |||
| ) | |||
|
|
|||
| // DetectionIndex creates an index for detection instances. | |||
| // WARNING: the detection index should not be used for prefixed iteration. | |||
There was a problem hiding this comment.
done. see 9218823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
In this PR I fixed a few issues that came up during an audit of the consensus code.
Added a warning comment on proper use of
DetectionIndex()Added safety checks to avoid potential nil dereference in the node's code. The potential nil dereference issues were found by Uber's nilaway tool (link).
nilaway's original reports are attached. Note, I did not fix potential errors in test code.
Removed the pairing query cache.
nilaway_reports.zip
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changemainbranchReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...