Enable gRPC-web calls on providers gRPC port #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirtayeb
reviewed
Nov 30, 2022
relayer/server.go
Outdated
Comment on lines
1151
to
1152
| resp.Header().Set("Access-Control-Allow-Methods", "POST, GET, OPTIONS, PUT, DELETE") | ||
| resp.Header().Set("Access-Control-Allow-Headers", "Accept, Content-Type, Content-Length, Accept-Encoding, X-CSRF-Token, Authorization, X-User-Agent, X-Grpc-Web, Grpc-Timeout") |
There was a problem hiding this comment.
better use use wildcard in both
There was a problem hiding this comment.
Yea agree, this was just copy-pasted from grpc-web library doc to make sure this works.
I will leave this conversation unresolved if we decide to go with this approach to remember to fix it.
Thank you for going over PR and leaving comments 🙏
There was a problem hiding this comment.
I've double-checked and concluded that we don't need to allow all of this, only the origin and headers needed for grpc-web. What do you think? :D
0xAleksaOpacic
force-pushed
the
feature/implement_grpcweb_listener
branch
from
94496ff
to
86f3e9d
Compare
0xAleksaOpacic
force-pushed
the
feature/implement_grpcweb_listener
branch
from
86f3e9d
to
52a9047
Compare
ranlavanet
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should enable that port that serves gRPC on the provider to accept gRPC-web calls as well. Provider needs to be able to receive gRPC-web calls or it would not be able to receive requests from SDK.
DoD:
Changes include