CNS-7: Enable consumer operation upon staking #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranlavanet
changed the title
SeanZoR
changed the title
SeanZoR
previously approved these changes
Nov 17, 2022
omerlavanet
requested changes
Nov 24, 2022
| ) | ||
|
|
||
| // Setup a new App for testing purposes | ||
| func TestSetup() (cosmoscmd.App, sdk.Context) { |
There was a problem hiding this comment.
test functions should be in a file ending with _test, go knows not to compile them, with the current name, it will be included in the binary
There was a problem hiding this comment.
this is just seting up for a test, not a test function in itself
There was a problem hiding this comment.
doesn't matter what is in the file, if it doesn't end with _test.go its compiled into the final binary and we dont need test helper functions in our binary
There was a problem hiding this comment.
if i do this it makes the file unusable outside of the package, since it becomes a test file
omerlavanet
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.