PRT-88: Prevent potential panic in the tendermintRPC #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! |
SeanZoR
suggested changes
Nov 17, 2022
Thanks, I opened it (PRT-88)! Next time I will use branch_naming from Jira (i can not change it now ) |
0xAleksaOpacic
changed the title
0xAleksaOpacic
changed the title
ranlavanet
requested changes
Nov 17, 2022
0xAleksaOpacic
force-pushed
the
fix/prevent_potential_panic
branch
from
3610625 to
0fdb6b8
Compare
SeanZoR
approved these changes
Nov 17, 2022
ranlavanet
requested changes
Nov 17, 2022
ranlavanet
requested changes
Nov 17, 2022
| ) | ||
|
|
||
| var ( | ||
| errFailedToConvertMessage = sdkerrors.New("RPC error", 1000, "failed to convert a message") |
There was a problem hiding this comment.
usually errors would be with a capital letter so they will be available for other packages as well
There was a problem hiding this comment.
No worries, we need to make our code as code as possible :D
I usually make them exportable only if they are used outside, but cool will follow structure we have 9d86272
There was a problem hiding this comment.
Fixed the build error 9b3d0d6
ranlavanet
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inside tendermintRPC.go we have potential panic. If these methods:
returns an error, rpcMessage object will be nil, which means that convertMsg method would not be able to extract fields and it will panic
Changes include