CNS-123: Remove chain query from the spec module #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanZoR
suggested changes
Nov 16, 2022
There was a problem hiding this comment.
@oren-lava please add Jira ticket to the PR subject, in the format of CNS-123: Remove chain query from ...
ranlavanet
approved these changes
Nov 16, 2022
ranlavanet
changed the title
SeanZoR
changed the title
SeanZoR
approved these changes
Nov 17, 2022
ranlavanet
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to rewrite very small parts of sentry.go that used the chain query (replaces it with show-Spec query). Ran and I tested the modified functions in sentry.go, and everything worked smoothly